On 1:10 27/03, Christoph Hellwig wrote: > On Thu, Mar 26, 2020 at 04:02:49PM -0500, Goldwyn Rodrigues wrote: > > BTRFS direct I/O is now done under i_rwsem, shared in case of > > reads and exclusive in case of writes. This guards against simultaneous > > truncates. > > Btw, you really want to add the optimization of only taking it shared > for all the easy write cases similar to what XFS has done for ages > and what ext4 picked up now. Without that performance on someworkloads > is going to be horrible. That could be a patch on top of this one, > though. Yes, I will work on that. The idea of dropping the lock seems a little weird. -- Goldwyn
