Excerpts from Xiao Guangrong's message of 2011-04-18 21:49:52 -0400: > On 04/12/2011 04:14 PM, Xiao Guangrong wrote: > > It doesn't allocate extent_state and check the result properly: > > - in set_extent_bit, it doesn't allocate extent_state if the path is not > > allowed wait > > > > - in clear_extent_bit, it doesn't check the result after atomic-ly allocate, > > we trigger BUG_ON() if it's fail > > > > - if allocate fail, we trigger BUG_ON instead of returning -ENOMEM since > > the return value of clear_extent_bit() is ignored by many callers > > > > Ping...to see what happened. :-) Sorry, could you please change this to check the results of the atomic allocatoin in set/clear_extent_bit? I'd rather not add a new BUG_ON deeper into the code. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
