On 04/13/2011 12:34 PM, Arne Jansen wrote:
On 13.04.2011 18:06, Josef Bacik wrote:There are a bunch of places where we do btrfs_join_transaction(root, 1), but really we set the block_rsv to the delalloc reserve because our metadata was reserved at delalloc time. This means we don't need to reserve space at all, and can just join the transaction and go. This patch also fixes a few places where we weren't actually setting the block_rsv to the delalloc reserve. Thanks, Signed-off-by: Josef Bacik<josef@xxxxxxxxxx> --- fs/btrfs/inode.c | 27 +++++++++++++++++---------- 1 files changed, 17 insertions(+), 10 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index c4b914e..e9bda50 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -420,7 +420,7 @@ again: } } if (start == 0) { - trans = btrfs_join_transaction(root, 1); + trans = btrfs_join_transaction(root, 0);btrfs_join_transaction ignores the num_blocks parameter, so this shouldn't change anything. Maybe it's cleaner to just eradicate the parameter.
Balls I forgot about that, though we should still be using the delalloc block reserve in the places that I put it. I'll just fix that up. Thanks,
Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
