On Thu, 2011-02-10 at 12:08 +0100, Thomas Bellman wrote: > On 2011-02-07 13:22, Eduardo Silva wrote: > > > Please find the attached patch which replace unsafe strcpy(3) by > > strncpy(3) functions. > > strncpy() doesn't NUL-terminate the destination buffer if the > maximum length is reached. And as far as I can see, there is > no other initialization of those buffers to zeroes, except for > super.label in make_btrfs() in utils.c. > > So please change those strncpy() calls to something like: > > strncpy(args.name, source, BTRFS_PATH_NAME_MAX); > args.name[BTRFS_PATH_NAME_MAX] = '\0'; > Seems like a string manipulation function is the way to go, will send a new patch shortly, best, Eduardo -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
