Re: [PATCH] Btrfs: do not BUG if we fail to remove the orphan item for dead snapshots

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Excerpts from Josef Bacik's message of 2010-12-10 08:30:36 -0500:
> On Fri, Dec 10, 2010 at 03:16:15PM +0800, Li Zefan wrote:
> > 01:25, Josef Bacik wrote:
> > > Not being able to delete an orphan item isn't a horrible thing.  The worst that
> > > happens is the next time around we try and do the orphan cleanup and we can't
> > > find the referenced object and just delete the item and move on.  Thanks,
> > > 
> > 
> > Would be better to add code comment? Otherwise later people may wonder why
> > the return value is not checked and see it as a bug.
> >
> 
> Comments are against Btrfs' coding style guidlines.

But not the new and improved coding style guidelines ;)

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux