On Mon, Nov 15, 2010 at 02:03:55PM -0500, Chris Mason wrote: > It always returns either -EIO or -EAGAIN, so the caller will try again > and then end up waiting on PageWriteback? Returning any error from ->writepage will make writeout return -EIO so aborting the migration for that page. If no error is returned from ->writepage, writeout will return -EAGAIN the caller will try again after wait_on_page_writeback. I think I misread the code when in prev mail I worried about not waiting on PG_writeback after writeout()... :) So the ideal would be not to return errors when ->writepage submitted the writeback I/O successfully but if it returns -EIO/-EAGAIN there's no risk whatsoever (except compaction will be less effective). -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
