On Sat, Nov 06, 2010 at 08:03:05PM +0900, Itaru Kitayama wrote:
>
> In the file sync path, file's parent inode is logged if it is newer than the last
> commit. This patch checks also the last_trans field as well as generation.
>
> As btrfs_log_inode updates the logged_trans field of parent dir's inode, tree-log
> lookup operations are suppressed upon unlink.
>
> The patch is for the latest btrfs-unstable tree.
>
> Signed-off-by: Itaru Kitayama <kitayama@xxxxxxxxxxxxx>
>
> ---
> fs/btrfs/tree-log.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index a29f193..db63ae4 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -3007,7 +3007,7 @@ int btrfs_log_inode_parent(struct btrfs_trans_handle *trans,
> if (root != BTRFS_I(inode)->root)
> break;
>
> - if (BTRFS_I(inode)->generation >
> + if (max(BTRFS_I(inode)->generation, BTRFS_I(inode)->last_trans) >
> root->fs_info->last_trans_committed) {
> ret = btrfs_log_inode(trans, root, inode, inode_only);
> if (ret)
Looks good to me,
Reviewed-by: Josef Bacik <josef@xxxxxxxxxx>
Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html