On Tuesday, 12 October, 2010, Ian Kent wrote: > On Mon, 2010-10-11 at 20:08 +0200, Goffredo Baroncelli wrote: [...] > > + ret = btrfs_unlink_subvol(trans, root, dir, > > + dest->root_key.objectid, > > + dentry->d_name.name, > > + dentry->d_name.len); > > + BUG_ON(ret); > > Is it really a good idea to add even more dead end BUG_ON() calls > instead of handling errors when they happen? > I agree with your comment, I copied these lines from the ioctl DESTROY_SUBVOL. Unfortunately I don't have the know-how to handle an error at this level. So I can only leave the code as the original one. [...] -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack@xxxxxxxxx> Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
