Re: [PATCH] Btrfs: handle kmalloc() failure in btrfs_file_aio_write()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/6/20 JieJing.Zhang <kzjeef@xxxxxxxxx>
>
> set errno to -ENOMEM and goto out
>
> Signed-off-by: JieJing.Zhang <kzjeef@xxxxxxxxx>
> ---
>  fs/btrfs/file.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
> index e354c33..e0fcb6c 100644
> --- a/fs/btrfs/file.c
> +++ b/fs/btrfs/file.c
> @@ -926,6 +926,10 @@ static ssize_t btrfs_file_aio_write(struct kiocb *iocb,
>                     PAGE_CACHE_SIZE, PAGE_CACHE_SIZE /
>                     (sizeof(struct page *)));
>        pages = kmalloc(nrptrs * sizeof(struct page *), GFP_KERNEL);
I think this gfp should changed to GFP_NOFS to avoid deadlock, right ?
like this commit: 33818bbb84cd371b63ed8849cc5264d24c8b3aa2
> +       if (!pages) {
> +               ret = -ENOMEM;
> +               goto out;
> +       }
>
>        /* generic_write_checks can change our pos */
>        start_pos = pos;
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux