Re: [PATCH] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/08/2010 03:07 PM, David Brown wrote:
On Thu, Apr 08, 2010 at 01:35:31PM -0700, Harshavardhana wrote:


    if (inode->i_size > BTRFS_EMPTY_DIR_SIZE ||
        inode->i_ino == BTRFS_FIRST_FREE_OBJECTID)
-        return -ENOTEMPTY;
+        return -EPERM;

Don't you want to still return ENOTEMPTY for the size check, and only
the EPERM on the root of subvolume?

David
Yep my bad.  i_size check has to be ENOTEMPTY

Thanks

--
Harshavardhana
http://www.gluster.com

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux