Andi Kleen wrote: > On Wed, Mar 24, 2010 at 11:08:07PM -0400, jim owens wrote: >> Agree, so the write design needs to prevent bad checksums. > > How? Do you have a plan for that? Yes... have Josef do it. ;) The options I considered are: 1 - buffer always for uncompressed, the same as compressed. 2 - checksum before bio_add_page and again before page_cache_release and fail or do buffering if checksum mismatch. 3 - write protect pages and block them in fault handler. #3 is done in other operating systems but is painful, so I would choose #2 because I think we can do more I/O that way at almost the same cpu cost as #1 and we don't double the memory use. jim -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
