Re: [PATCH] btrfs-progs: add mounted-checking for btrfs-vol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

on 2010-2-2 17:08, Wengang Wang wrote:
[snip]
>>  		devfd = open(device, O_RDWR);
>>  		if (!devfd) {
> I think open() returning -1 means an error. So it should be
> 		if (devfd < 0)
> instead of 
> 		if (!devfd)

Yes, you are right. 
Thanks for your comment. I'll remake a patch.

Regards
Miao

> 
> regards,
> wengang.
>>  			fprintf(stderr, "Unable to open device %s\n", device);
>> +			exit(1);
>>  		}
>>  		ret = fstat(devfd, &st);
>>  		if (ret) {
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux