Chris Mason wrote: > On Thu, Nov 12, 2009 at 04:14:26PM +0900, TARUISI Hiroaki wrote: >> From: Christian Parpart <trapni@xxxxxxxxxx> >> >> I rebased Christian Parpart's patch to deny hard link across >> subvolumes. Original patch modifies also btrfs_rename, but >> I excluded it because we can move across subvolumes now and >> it make no problem. > > Thanks for sending this in again. > > Actually, we still can't rename across subvolumes, but we do support > renaming subvolumes. Do you have some time to add more checks to rename > as well? > > -chris > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Thank you for your reply. I tried moving file/directory/subvolume across subvolumes, and found it worked. In source code of btrfs_rename, it's already checked if 'from' directory and 'to' directory are under a same root or not except a root object. If not matched, btrfs_rename returns with -EXDEV but it seems mv command treats it properly. Even if in no-check case (root object case), I tried but found no serious problem. I wonder renaming subvolumes across subvolumes does not completely work yet in some points I cannot found, or btrfs_rename works without returning -EXDEV. Could you tell me how should we check when renaming subvolumes? Regards, taruisi -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
