Re: Proper error handling on NULL pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 21, 2009 at 07:43:51PM +0200, Diego Calleja wrote:
> On Lunes 19 Octubre 2009 12:36:13 Andi Drebes escribió:
> > However, is there any interest in patches fixing these problems? If yes: what would be the best strategy? Should we start fixing this "layer by layer" -- the low-level functions first and the high-level functions later on? Or should use come kind of "vertical approach" -- one low-level function and all of its callers at once?
> 
> I don't know what is the developer plan to fix that - apparently it's
> not in the high-priority list (but it must be certainly in the priority
> list, anyone who gets out of memory using btrfs will have some chances of
> getting an oops - but notice that most of the important paths are ready
> to handle errors reliably and there aren't many bug reports due to bad
> oom handling, so it doesn't seems to be that critical).

On thing to remember on the allocator is that when you're asking for
one page or less in kmalloc the allocator will generally oom the box before it
returns null.

So, I'm not suggesting we aren't going to fix these but that's why they
haven't turned into any bug reports yet.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux