On Mon, 6 Jul 2009 01:29:14 -0400 Amerigo Wang <amwang@xxxxxxxxxx> wrote: > > file_remove_suid() should be called with i_mutex held, > file_update_time() too. So move them after mutex_lock(). > > Plus, check the return value of kmalloc(). > > Signed-off-by: WANG Cong <amwang@xxxxxxxxxx> > > --- > diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c > index 7c3cd24..cd36301 100644 > --- a/fs/btrfs/file.c > +++ b/fs/btrfs/file.c > @@ -944,14 +944,17 @@ static ssize_t btrfs_file_write(struct file > *file, const char __user *buf, if (count == 0) > goto out_nolock; > > + mutex_lock(&inode->i_mutex); > + > err = file_remove_suid(file); > if (err) > - goto out_nolock; > + goto out; > file_update_time(file); > > pages = kmalloc(nrptrs * sizeof(struct page *), GFP_KERNEL); > + if (!pages) > + goto out; > Hi, I don't think you can keep this at GFP_KERNEL once you hold i_mutex.... very likely this needs to now turn into GFP_NOFS! -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
