Jeff Mahoney <jeffm@xxxxxxxx> writes: > wake_up_process(root->fs_info->cleaner_kthread); > @@ -2197,10 +2199,12 @@ int btrfs_commit_super(struct btrfs_root > btrfs_clean_old_snapshots(root); > mutex_unlock(&root->fs_info->cleaner_mutex); > trans = btrfs_start_transaction(root, 1); > + BUG_ON(IS_ERR(trans)); Would it make sense to use a different macro for things that are expected to be fixed later? BUG_ON_I_SUCK() or TMP_BUG_ON() or something like that? I think that would make it clearer that things are only temporary. At least it should be documented somewhere. -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
