Re: [PATH]Some fix for batching extent insert.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-11-17 at 23:48 +0800, Liu Hui wrote:
> Hi,
> When I review the code about batching extent insert, I found some code
> could result in problems in some corner cases.
> 1)In finish_current_insert(), when it finds nothing to insert and it
> has skipped some locked extents, it should try again to see if the
> locked extent is unlocked. So, it will re-search the extent_ins
> extent_io_tree by reseting 'search' to 0. There is one place forget to
> reset the 'search' pointer to 0 which will lead BTRFS not to finish
> *all* current insert.
> 

Thanks for spending time on this, but I'm afraid this patch leads to
infinite looping in finish_current_insert under stress testing.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux