Re: [PATCH 4/4] Add fallocate support v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2008-10-31 at 01:02 +0800, Yan Zheng wrote:
> Hello,
> 
> This patch updates btrfs-progs for fallocate support.

Thanks for rediffing these, one question though:

> diff -urp 4/fs/btrfs/ctree.h 5/fs/btrfs/ctree.h
> --- 4/fs/btrfs/ctree.h	2008-10-30 13:45:33.000000000 +0800
> +++ 5/fs/btrfs/ctree.h	2008-10-30 14:21:24.000000000 +0800
> @@ -462,8 +462,9 @@ struct btrfs_root_item {
>  	u8 level;
>  } __attribute__ ((__packed__));
>  
> -#define BTRFS_FILE_EXTENT_REG 0
> -#define BTRFS_FILE_EXTENT_INLINE 1
> +#define BTRFS_FILE_EXTENT_INLINE 0
> +#define BTRFS_FILE_EXTENT_REG 1
> +#define BTRFS_FILE_EXTENT_PREALLOC 2

Why do we swap these around?

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux