Re: [PATCH] btrfs-progs: autotoolized and splitup into {libbtrfs,tools,tests}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2008-10-10 at 03:01 +0200, Christian Parpart wrote:
> whether  btrfs to be using autotools or not, the other kind this patch 
> addressed seems to be more important to me: project modularization.

That makes a certain amount of sense, but should definitely be submitted
as a separate patch. And it would probably be best to generate it with
'git-diff -M' so that renamed files are shown as such. rather than
deletion and addition. That'll make your patch far more reviewable.

I'm still not convinced that third party code should be linking against
a libbtrfs just yet, but that doesn't mean it shouldn't be set up to
allow that to happen in future.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@xxxxxxxxx                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux