Zach Brown wrote:
Avi Kivity wrote:
I've been reading btrfs's on-disk format, and two things caught my eye
- attribute((packed)) structures everywhere, often with misaligned
fields. This conserves space, but can be harmful to in-memory
performance on some archs.
How harmful? Do you have any profiles that can even pick this out of
the noise?
On those archs that take faults on unaligned accesses it's unlikely to
be in the noise. But we could (and should) stick a get_unaligned() in
the accessor functions.
uleb128 encoding is orthogonal to this issue, however. It's only about
getting better density.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
