On Tue, 2008-08-19 at 07:54 -0400, Chris Mason wrote: > > > What if the parent inode actually _is_ inode #0xffffffffffffffff? Can > > that happen? In that case it would return zero, and I shouldn't subtract > > 1 from the slot number -- I've actually found what I'm looking for? > > > > The max inode will be 2^64 - 1 Which is what we're searching for -- so it's _possible_, albeit vanishingly unlikely, that btrfs_search_slot() will actually return zero, having found precisely what we wanted? And in that case, path->slots[0] being zero is fine. And we shouldn't be subtracting one from it to find the slot we want? -- David Woodhouse Open Source Technology Centre David.Woodhouse@xxxxxxxxx Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
