On Sun, 2008-08-17 at 18:54 +0530, Balaji Rao wrote: > > > OK. I had copied over this code snippet from > inode.c:btrfs_inode_by_name, > which has the condition 'if (slot >= nritems)' removed now by this. > > changeset: 631:87490dc3bb59 > user: "Yan Zheng" <yanzheng@xxxxxxxx> > date: Thu Jul 24 12:19:32 2008 -0400 > summary: Fix .. lookup corner case > > I think we should refactor btrfs_inode_by_name into something we can > use ? I'm not entirely sure why btrfs_inode_by_name() handles "." and ".." at all. We haven't needed that since the 2.2 kernel, have we? I think we should just remove that code completely -- and remove the similar code from btrfs_real_readdir() while we're at it -- just use parent_ino(filp->f_path.dentry) instead. In _that_ case, we know the dcache is connected. -- David Woodhouse Open Source Technology Centre David.Woodhouse@xxxxxxxxx Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
