Re: [PATCH] implement memory reclaim for leaf reference cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2008-07-30 at 14:14 -0400, Chris Mason wrote:
> On Wed, 2008-07-30 at 23:52 +0800, Yan Zheng wrote:
> > Hello,
> > 
> > The memory reclaiming issue happens when snapshot exists. In that
> > case, some cache entries may not be used during old snapshot dropping,
> > so they will remain in the cache until umount. The patch adds a field
> > to struct btrfs_leaf_ref to record create time. Besides, the patch
> > makes all dead roots of a given snapshot linked together in order of
> > create time. After a old snapshot was completely dropped, we check the
> > dead root list and remove all cache entries created before the oldest
> > dead root in the list.
> > 
> 
> Hi Yan,
> 
> I think this is missing some hunks, it isn't compiling quite right:
> 

Well, outside of these errors the code looks right.  I'll push it out,
just send along an incremental if it is needed.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux