On Wed, 2008-05-21 at 14:02 -0400, Chris Mason wrote: > On Wednesday 21 May 2008, Mingming wrote: > > Hi Chris, > > > > btrfs failed to compile on 2.6.26-rc2 since the put_inode callback > > function is removed from super_operations. > > > > I noticed btrfs_put_inode() seems being actively used, to drop the inode > > from the tree for ordered mode transaction. Any idea where to relocate > > this function? Do we need to call btrfs_del_ordered_inode() for every > > iput()? > > The ordered inode list has incremented the inode->i_count, so we can't do the > iput code inside clear_inode. But, we should be able to safely move the > checks to file_release. > Ah okay. file release is called on the last file_close() to this inode. But I thought NFS could grab the inode without thr file_open/file_close, so we might also need to delete the inode from the ordered tree at delete_inode time, like ext3? > This is basically an optimization so that we don't leave clean inodes hanging > around on the data=ordered list. It is safe to remove the put_inode call > completely, it'll just be a little slower. > > -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
