Re: [PATCH] xfstest: Cleanup test permission and gitignore state.
On 6/1/12 8:18 AM, Alain Renaud wrote: > > The new test 284/285/286 do not have execute permission set so set > them. Also test 285 and 286 create 2 executable that are not in .gitignore > so add then to the list. > > Signed-off-by: Alain Renaud <arenaud@xxxxxxx> Looks good to me, Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> I wonder if we can embed something in the ./check script to check executable state and fail if not set - we check things in w/o execute perms all the time and we're constantly having to fix things up. It's just tidiness really, but a bit of a pain.... -Eric > diff --git a/.gitignore b/.gitignore > index 900ff95..c53c0d9 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -88,6 +88,8 @@ src/aio-dio-regress/aio-dio-subblock-eof-read > src/aio-dio-regress/aio-free-ring-with-bogus-nr-pages > src/aio-dio-regress/aio-io-setup-with-nonwritable-context-pointer > src/aio-dio-regress/aiodio_sparse2 > +src/seek_copy_test > +src/seek_sanity_test > dmapi/src/common/cmd/read_invis > dmapi/src/common/cmd/set_region > diff --git a/284 b/284 > old mode 100644 > new mode 100755 > diff --git a/285 b/285 > old mode 100644 > new mode 100755 > diff --git a/286 b/286 > old mode 100644 > new mode 100755 > > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs