Re: [PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Mon, Apr 09, 2012 at 02:36:21PM -0400, Bryan Schumaker wrote:
> The cleanup function is trapped before _require_scratch() is called, and
> then expands "rm -rf $SCRATCH_MNT/*" to "rm -rf /*"

It doesn't need to clean up the scratch device - tests need to mkfs
it first before using it, so just remove the $tmp* files. The sae
fix is needed for tests 274 and 275.

Also, it shouldn't be using "-rf" to do cleanup - "rm -f $tmp.*" is
sufficient to remove all the tmp files...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux