Re: [PATCH 1/2 v2] sh_mobile_ceu: add soft reset function

[Magnus Damm <magnus.damm@xxxxxxxxx>]

Hi Morimoto-san,

Thanks for your work on this.

On Thu, Aug 6, 2009 at 9:49 AM, Kuninori
Morimoto<morimoto.kuninori@xxxxxxxxxxx> wrote:
>
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> ---
> v1 -> v2
>
> o it use msleep
> o it judge in_atomic or not
>
> it judge in_atomic because sh_mobile_ceu_soft_reset
> will also be called from atomic.

If the time required for soft reset is short enough then you probably
want to use udelay() instead. And if soft delay takes long time then
you don't want to do it from interrupt context anyway. Please update
the patch after summer vacation.

Cheers,

/ magnus

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list