Re: [PATCH] soc-camera: fix missing clean up on error path

[Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>]

Dear Guennadi

> If soc_camera_init_user_formats() fails in soc_camera_probe(), we have to call
> client's .remove() method to unregister the video device.
> 
> Reported-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
> Hi Morimoto-san
(snip)
> Could you please verify that this patch fixed your problem?

Thank you nice patch.
I tried this, but kernel stoped in boot.

soc_camera_video_stop is called from icd->ops->remove 
I think it have dead lock by icd->video_lock.

my kernel is from Paul's git and it's Makefile said 2.6.30-rc6

Best regards
--
Kuninori Morimoto
 

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list