Re: [PATCH] resistor setting sequence fix on ov772x

[Guennadi Liakhovetski <g.liakhovetski@xxxxxx>]

Hi Morimoto-san,

On Tue, 13 Jan 2009, Kuninori Morimoto wrote:

> soc_camera framework require that resistor setting is done on set_fmt,
> and start_capture and stop_capture control only camera on/off.
> This patch modify ov772x to this style.
> 
> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>

I'm applying this patch, but I changed the subject and the description a 
bit:

====================

Subject: [PATCH] ov772x: move configuration from start_capture() to set_fmt()

soc_camera framework requires, that camera configuration is performed in
set_fmt, and start_capture and stop_capture only turn the camera on/off.
This patch modifies ov772x to comply to this requirement.

====================

Agree? I just have no idea whether it's resistors or capacitors or 
anything else that gest set by those i2c commands:-)

One more comment to your ov772x driver: at present S_CROP is not supported 
and it would just fail if anyone attempts to crop the image. Could you 
please fix? You have to process the pixfmt == 0 case in set_fmt for this.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list