Re: [PATCH] video: sh_mobile_ceu cleanups and comments V2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 17 Dec 2008, Guennadi Liakhovetski wrote:

> On Tue, 16 Dec 2008, Magnus Damm wrote:
> 
> > From: Magnus Damm <damm@xxxxxxxxxx>
> 
> Magnus, sorry, looks like you missed a couple more:

Ok, forget it, if you don't mind, I'll just do it myself.

Thanks
Guennadi

> 
> > @@ -452,13 +459,13 @@ static int sh_mobile_ceu_set_bus_param(s
> 
> 	if ((icd->current_fmt->fourcc == V4L2_PIX_FMT_NV21) ||
> 	    (icd->current_fmt->fourcc == V4L2_PIX_FMT_NV61))
> 		value ^= 0x00000100; /* swap U, V to change from NV1x->NVx1 */
> 
> 	value |= (common_flags & SOCAM_VSYNC_ACTIVE_LOW) ? (1 << 1) : 0;
> 	value |= (common_flags & SOCAM_HSYNC_ACTIVE_LOW) ? (1 << 0) : 0;
> 	value |= (buswidth == 16) ? (1 << 12) : 0;
> 
> Let's make it complete, ok?
> 
> >  
> >  	if (yuv_mode) {
> >  		width = icd->width * 2;
> > -		width = (buswidth == 16) ? width / 2 : width;
> > +		width = buswidth == 16 ? width / 2 : width;
> >  		cfszr_width = cdwdr_width = icd->width;
> >  	} else {
> >  		width = icd->width * ((icd->current_fmt->depth + 7) >> 3);
> > -		width = (buswidth == 16) ? width / 2 : width;
> > -		cfszr_width = (buswidth == 8) ? width / 2 : width;
> > -		cdwdr_width = (buswidth == 16) ? width * 2 : width;
> > +		width = buswidth == 16 ? width / 2 : width;
> > +		cfszr_width = buswidth == 8 ? width / 2 : width;
> > +		cdwdr_width = buswidth == 16 ? width * 2 : width;
> >  	}
> >  
> >  	ceu_write(pcdev, CAMOR, 0);
> > 
> 
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

[Index of Archives]     [Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Linux Kernel]     [Asterisk]     [DCCP]     [Netdev]     [X.org]     [Util Linux]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [DVB Maintainers]     [Linux USB]     [Yosemite Information]
  Powered by Linux