Re: [PATCH] Add tw9910 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 15, 2008 at 6:11 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> On Mon, 15 Dec 2008, Magnus Damm wrote:
>> On Mon, Dec 15, 2008 at 5:33 PM, Guennadi Liakhovetski
>> <g.liakhovetski@xxxxxx> wrote:
>> > Good, then passing it directly to the camera driver should be enough for
>> > now.
>>
>> Yeah. I guess this all means that we have to rework things a bit. So
>> the interlace patch needs to be updated. Which affects my cleanup
>> patch. Do you have any preference on how to proceed? I'd go with just
>> keep on adding things - this means my cleanup patch that i'm about to
>> send will still apply - but I'm fine rewriting and reposting as well.
>
> As you see, patches
>
> [PATCH 02/03] sh_mobile_ceu: add NV12 and NV21 support
> [PATCH] Add interlace support to sh_mobile_ceu_camera.c
> [PATCH] Add tw9910 driver
>
> need modifications, so, I would prefer to have them re-done instead of
> incrementally fixing them. This doesn't include of course parenthesis and
> ceu_write / ceu_read typing fixes to existing code - this should be a
> separate patch.

Hm, I thought you only needed a NV12 patch consisting of more or less
cosmetic changes? I guess the dma_addr_t change may be in a gray zone
though. I'd prefer not to touch the NV12 and NV16 patches except for a
cleanup patch if possible, but I will of course update and resend the
NV12 patch if you prefer that.

> BTW, you realise, that I'm not handling this your patch:
>
> [PATCH] videobuf-dma-contig: fix USERPTR free handling
>
> Have you got an ack for it yet?

No, I haven't. Not so strange though since that the CEU driver is the
only user. =) And most programs simply do mmap() so I don't think
Morimoto-san is running into this issue. But getting it included would
be great. Also the NV16 fourcc definitions would be nice to have
included.

Thanks.

/ magnus

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

[Index of Archives]     [Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Linux Kernel]     [Asterisk]     [DCCP]     [Netdev]     [X.org]     [Util Linux]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [DVB Maintainers]     [Linux USB]     [Yosemite Information]
  Powered by Linux