gspca: fix vidioc_s_jpegcomp locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This locking looked wrong.

-jim

--

gspca: fix vidioc_s_jpegcomp locking

Signed-off-by: Jim Paris <jim@xxxxxxxx>

diff -r b50857fea6df linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c	Tue Dec 09 16:20:31 2008 -0500
+++ b/linux/drivers/media/video/gspca/gspca.c	Tue Dec 09 16:55:39 2008 -0500
@@ -1320,10 +1320,10 @@
 	struct gspca_dev *gspca_dev = priv;
 	int ret;
 
+	if (!gspca_dev->sd_desc->set_jcomp)
+		return -EINVAL;
 	if (mutex_lock_interruptible(&gspca_dev->usb_lock))
 		return -ERESTARTSYS;
-	if (!gspca_dev->sd_desc->set_jcomp)
-		return -EINVAL;
 	ret = gspca_dev->sd_desc->set_jcomp(gspca_dev, jpegcomp);
 	mutex_unlock(&gspca_dev->usb_lock);
 	return ret;

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

[Index of Archives]     [Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Linux Kernel]     [Asterisk]     [DCCP]     [Netdev]     [X.org]     [Util Linux]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [DVB Maintainers]     [Linux USB]     [Yosemite Information]
  Powered by Linux