Re: [PATCH] Add OMAP2 camera driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vaibhav,

> [Hiremath, Vaibhav] I can tell you that for OMAP3 we do have lot of files coming in, and it really brings more confusion if we have OMAP1 and OMAP2 lying outside and OMAP3 code (Display + capture) say under omap/ or omap3/.
>

If you want OMAP3 directory I am fine with that but I still don't see
need of omap2 and omap1 files under omap directory.

> It makes sense to have omap/ directory, and all the versions/devices of OMAP get handled from omap/Kconfig and omap/Makefile. Even if they have single file it would be nice to follow directory layers.
>
> Hans, Sakari or Mauro can provide their opinion on this, and decide how to handle this.
>
> I am just providing details, so that it would be easy to take decision -
>
> OMAP1 - (I have listed names from old O-L tree)
>        - omap16xxcam.c
>        - camera_core.c
>        - camera_hw_if.h
>        - omap16xxcam.h
>        - camera_core.h

In the long run (??) this will reduce to...

omap1cam.c
omap1cam.h

as there is not need to creating this hw_if as the only user of this
interface is omap16xx. I don't see any need cam_core abstraction at
all.

>
> OMAP2 - (I have listed names from old O-L tree)
>        - omap24xxcam.c
>        - omap24xxcam-dma.c
>        - omap24xxcam.h

This is already accepted by Hans and going to be mainlined once merge
window opens.

>
> In future may be display will add here.
>
> OMAP3 -
>        Display - (Posted twice with old DSS library)
>                - omap_vout.c
>                - omap_voutlib.c
>                - omap_voutlib.h
>                - omap_voutdef.h
>        Camera - (Will come soon)
>                - omap34xxcam.c
>                - omap34xxcam.h
>        ISP - (Will come soon)
>                - Here definitely we will plenty number of files.

ISP block would be generic enough to be used on other silicons also,
right? What if it is on Davinci line of processors?


-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

[Index of Archives]     [Linux Media]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Linux Kernel]     [Asterisk]     [DCCP]     [Netdev]     [X.org]     [Util Linux]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [SSH]     [DVB Maintainers]     [Linux USB]     [Yosemite Information]
  Powered by Linux