Re: [PATCH] V4L: Int if: Define new power state changes

[Hans Verkuil <hverkuil@xxxxxxxxx>]

On Tuesday 07 October 2008 18:17:48 Sakari Ailus wrote:
> ext Hans Verkuil wrote:
> > Hi Sakari,
> >
> > I'm OK with the other changes, but the V4L2_POWER_RESUME command in
> > this patch is still really very ugly. In my opinion you should
> > either let the slave store the old powerstate (this seems to be the
> > more logical approach), or let s_power pass the old powerstate as
> > an extra argument if you think it is really needed. But the RESUME
> > command is just unnecessary. Without the RESUME there is no more
> > need to document anything, since then it is suddenly
> > self-documenting.
>
> Yeah, I agree. I'll remove that and send a new patchset, this time
> with git-format-patch -n. :-)
>
> Ps. Last time the first patch got caught by a spam filter and my
> hunch is that it'll happen again.

No problems this time.

Anyway, here is my SoB for this series of 6 patches:

Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx>

Mauro, can you merge there patches directly, or do you want me to setup 
a v4l-dvb tree for you that you can merge from?

Thanks,

	Hans

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list