Re: [PATCH] V4L: Int if: Define new power state changes

Sakari Ailus <sakari.ailus@xxxxxxxxx> · Tue, 07 Oct 2008 19:17:48 +0300

ext Hans Verkuil wrote:

Hi Sakari,

I'm OK with the other changes, but the V4L2_POWER_RESUME command in this 

patch is still really very ugly. In my opinion you should either let 

the slave store the old powerstate (this seems to be the more logical 

approach), or let s_power pass the old powerstate as an extra argument 

if you think it is really needed. But the RESUME command is just 

unnecessary. Without the RESUME there is no more need to document 

anything, since then it is suddenly self-documenting.

Yeah, I agree. I'll remove that and send a new patchset, this time with
git-format-patch -n. :-)

Ps. Last time the first patch got caught by a spam filter and my hunch 

is that it'll happen again.

Regards,

--
Sakari Ailus
sakari.ailus@xxxxxxxxx

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list