Re: RFC: move zoran/core/i2c drivers to separate directories

[Hans Verkuil <hverkuil@xxxxxxxxx>]

On Friday 03 October 2008 14:07:06 Andy Walls wrote:
> On Fri, 2008-10-03 at 13:13 +0200, Hans Verkuil wrote:
> > Hi all,
> >
> > It looks like 2.6.27 is nearing completion, so this is a good time
> > to reorganize the video tree. IMHO it's getting rather messy in the
> > media/video directory and I propose to make the following changes:
> >
> > 1) the zoran driver sources are moved into a video/zoran directory.
> > 2) the v4l core sources (v4l* and videobuf*) are moved into a
> > video/core directory. Since I'll be adding more v4l core sources in
> > the near future this would keep everything together nicely.
> >
> > 3) the i2c drivers are moved to either media/video/i2c or media/i2c
> > (I have no preference). This should make it easier to see what is
> > the actual v4l driver and what is a supporting i2c driver. It's
> > rather mixed up right now.
>
> If the i2c drivers can be shared with Digital Video cards, then
> media/video/i2c probably isn't the best.  media/i2c or
> media/common/i2c might be better.

They can in theory, but it will take quite some time before that becomes 
reality (if ever). Personally I think that we should keep it for now 
within the video directory and move it up as soon as dvb will start 
using it. But I have no strong preference.

> <thinking out loud>
>
> Would there be something more descriptive than "i2c"? That describes
> the bus to which the support chips connect, but lumps together audio
> multiplexers, eeproms, analog broadcast decoders, etc., right?
>
> Classification by bus interface doesn't seem to have a strong
> precedent. The rest of the kernel generally doesn't appear to lump
> every device with a common interface under a directory, but instead
> devices with common functions (drivers/scsi, drivers/video,
> drivers/net).  I should note though that the drivers/char directory
> has survived with a big pile of "stuff" for quite some time.
>
> How about media/video/ancillary or media/common/ancillary to cover
> ancillary support chips and functions that are otherwise unclassified
> in the directory structure/taxonomy?
>
> </thinking out loud>

Hmm, ancillary is a bit long. What about clients? Since these are all 
(i2c) clients on a (usually i2c) bus. Besides, I'll be introducing a 
struct media_client soon that all these drivers will support. 'struct 
media_ancillary' sounds weird to me.

>
> To bring it up a level, you have identified a requirement to simplify
> something and have an implicit measure of complexity (logically
> unrelated files in the host driver directory?) that you'd like to
> reduce.  So what does it take to meet that requirement without
> increasing some other undesirable measure: the count of directories
> under linux/drivers/media or how many files do my "grep -R" searches
> have to wade through now? :)

1) Moving zoran sources into a zoran directory reflects current 
practice.
2) We could prefix all core files with a common prefix (v4l2_) as an 
alternative. But I think it is cleaner to have a core directory 
instead.
3) Ditto for all i2c drivers, but there are so many that I think these 
really should be moved to their own directory.

> > There are probably some sources where it is not clear where they
> > should go (e.g. ir-kbd-i2c.c), when in doubt I prefer to keep them
> > where they are now, they can always be moved later.
>
> "ancillary", or something similar, covers ancillary support chips and
> functions like ir-kdb-i2c.c and tveeprom.c.

I agree.

Thank you for the feedback.

Regards,

	Hans

> But it's all semantics I suppose.
>
> Regards,
> Andy
>
> > Are there any objections? Suggestions?
> >
> > Regards,
> >
> > 	Hans
> >
> > --
> > video4linux-list mailing list
> > Unsubscribe
> > mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
> > https://www.redhat.com/mailman/listinfo/video4linux-list


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list