RE: [PATCH 11/15] OMAP3 camera driver: Add ISP gain tables.

["Aguirre Rodriguez, Sergio Alberto" <saaguirre@xxxxxx>]

Patch file attached.

Thanks for your time, I appreciate it. We are taking all the comments we got from everybody, and trying to generate a new set of patches.

Regards,
Sergio

-----Original Message-----
From: Hans Verkuil [mailto:hverkuil@xxxxxxxxx] 
Sent: Tuesday, September 02, 2008 1:22 AM
To: video4linux-list@xxxxxxxxxx
Cc: Aguirre Rodriguez, Sergio Alberto
Subject: Re: [PATCH 11/15] OMAP3 camera driver: Add ISP gain tables.

On Saturday 30 August 2008 01:42:23 Aguirre Rodriguez, Sergio Alberto 
wrote:
> From: Sergio Aguirre <saaguirre@xxxxxx>
> 
> OMAP: CAM: Add ISP gain tables
> 
> This adds the OMAP ISP gain tables. Includes:
> * Blue Gamma gain table
> * CFA gain table
> * Green Gamma gain table
> * Lens Shading Compensator gain table
> * Luma Enhancement gain table
> * Noise filter gain table
> * Red Gamma gain table
> 
> Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
> ---
>  drivers/media/video/isp/bluegamma_table.h    | 1040 
+++++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/media/video/isp/cfa_coef_table.h     |  592 
+++++++++++++++++++++++++++++
>  drivers/media/video/isp/greengamma_table.h   | 1040 
+++++++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/media/video/isp/ispccd_lsc.dat       |   97 ++++

Can you mail this again, but this time attach the patch? The 
ispccd_lsc.dat patch was corrupted due to the extremely long lines. 
BTW, the whole table has only 0x40 values in it. Perhaps time for a 
memset 0x40? Also, since ispccd_lsc.dat is included in a source I 
recommend renaming it to a .h file.

In general, please cleanup these headers. So rather than doing this:

/*
 * CFA Filter Coefficient Table
 *
 */
static u32 cfa_coef_table[] = {
#include "cfa_coef_table.h"
};

just move this to the cfa_coef_table.h header.

And instead of having the data layouted like this:

0,
247,
0,
244,
247,
36,
27,
12,
0,
27,
0,
250,

try to do it like this:

	  0, 247,   0, 244, 247,  36,
	 27,  12,   0,  27,   0, 250,

using, say, 8 or 10 values per line.

Regards,

	Hans

Attachment: 011_OMAP_CAM_Add_ISP_gain_tables.patch
Description: 011_OMAP_CAM_Add_ISP_gain_tables.patch

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list