Re: [PATCH 2/15] OMAP3 camera driver: V4L2: Adding internal IOCTLs for crop.

[Hans Verkuil <hverkuil@xxxxxxxxx>]

On Sunday 31 August 2008 15:30:55 Aguirre Rodriguez, Sergio Alberto 
wrote:
> Hi Hans,
> 
> I think that it has been detected by the list mail server to have a 
suspicious header name, and therefore not finally sent to the list.
> 
> I'm not at my work pc right now, but i'll be resending the patch 
tomorrow morning (9:00 AM, GMT -6) to see if i still have the same 
error.
> 
> Thanks for all the comments, we will be fixing those aswell starting 
tomorrow.
> 
> These set of patches should apply cleanly on top of MontaVista kernel 
v2.6.27-rc3. They are ready for V4L api changes until that kernel 
version (changes in video_device, ioctls).

Note that the v4l-dvb tree (http://linuxtv.org/hg/v4l-dvb/) is always 
the latest tree and the tree against which you will merge your code. 
This tree is basically what will go to 2.6.28 so that should be your 
target. 2.6.27-rc3 is old already :-)

Regards,

	Hans

> 
> Regards,
> Sergio
> ________________________________________
> From: Hans Verkuil [hverkuil@xxxxxxxxx]
> Sent: Saturday, August 30, 2008 3:34 PM
> To: video4linux-list@xxxxxxxxxx
> Cc: Aguirre Rodriguez, Sergio Alberto
> Subject: Re: [PATCH 2/15] OMAP3 camera driver: V4L2: Adding internal 
IOCTLs for crop.
> 
> Hi,
> 
> Did something happen to PATCH 1/15? Patch 2/15 is the first I see.
> 
> Some initial comments (things seen when scanning through the patches):
> 
> - Please add a small comment at the top of the driver sources 
explaining
> what a certain abbreviation means (e.g. 'ISP', 'H3A', etc.) and what
> the driver does.
> 
> - Patch 10 seems to have some devfs support (resizer). Devfs is dead 
and
> should not be used.
> 
> - The previewer uses register_chrdev while the resizer uses
> alloc_chrdev_region. The latter is the preferred solution since
> register_chrdev allocates a block of 256 minors, which seems to be
> overkill.
> 
> - The previewer and resizer basically create a new public API. Can you
> give a short description of that API and how it is used? I need some
> more information about it. In general I would say that a document
> describing these drivers and esp. the driver-specific public API is
> required.
> 
> - Can you test whether these patches apply to the latest v4l-dvb
> repository? There have been a lot of changes this weekend and it is
> probably good to check this.
> 
> Regards,
> 
>         Hans
> 
> 
> On Saturday 30 August 2008 01:37:11 Aguirre Rodriguez, Sergio Alberto
> wrote:
> > From: Sameer Venkatraman <sameerv@xxxxxx>
> >
> > V4L2: Adding internal IOCTLs for crop.
> >
> > Adding internal IOCTLs for crop.
> >
> > Signed-off-by: Sameer Venkatraman <sameerv@xxxxxx>
> > Signed-off-by: Mohit Jalori <mjalori@xxxxxx>
> > ---
> >  include/media/v4l2-int-device.h |    6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > Index: linux-omap-2.6/include/media/v4l2-int-device.h
> > ===================================================================
> > --- linux-omap-2.6.orig/include/media/v4l2-int-device.h       
2008-08-25
> > 12:19:09.000000000 -0500 +++
> > linux-omap-2.6/include/media/v4l2-int-device.h        2008-08-25
> > 12:19:10.000000000 -0500 @@ -170,6 +170,9 @@
> >       vidioc_int_queryctrl_num,
> >       vidioc_int_g_ctrl_num,
> >       vidioc_int_s_ctrl_num,
> > +     vidioc_int_cropcap_num,
> > +     vidioc_int_g_crop_num,
> > +     vidioc_int_s_crop_num,
> >       vidioc_int_g_parm_num,
> >       vidioc_int_s_parm_num,
> >
> > @@ -266,6 +269,9 @@
> >  V4L2_INT_WRAPPER_1(queryctrl, struct v4l2_queryctrl, *);
> >  V4L2_INT_WRAPPER_1(g_ctrl, struct v4l2_control, *);
> >  V4L2_INT_WRAPPER_1(s_ctrl, struct v4l2_control, *);
> > +V4L2_INT_WRAPPER_1(cropcap, struct v4l2_cropcap, *);
> > +V4L2_INT_WRAPPER_1(g_crop, struct v4l2_crop, *);
> > +V4L2_INT_WRAPPER_1(s_crop, struct v4l2_crop, *);
> >  V4L2_INT_WRAPPER_1(g_parm, struct v4l2_streamparm, *);
> >  V4L2_INT_WRAPPER_1(s_parm, struct v4l2_streamparm, *);
> >
> >
> > --
> > video4linux-list mailing list
> > Unsubscribe
> > mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
> > https://www.redhat.com/mailman/listinfo/video4linux-list
> 
> 


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list