Re: [PATCH 2/15] OMAP3 camera driver: V4L2: Adding internal IOCTLs for crop.

[Hans Verkuil <hverkuil@xxxxxxxxx>]

Hi,

Did something happen to PATCH 1/15? Patch 2/15 is the first I see.

Some initial comments (things seen when scanning through the patches):

- Please add a small comment at the top of the driver sources explaining 
what a certain abbreviation means (e.g. 'ISP', 'H3A', etc.) and what 
the driver does.

- Patch 10 seems to have some devfs support (resizer). Devfs is dead and 
should not be used.

- The previewer uses register_chrdev while the resizer uses 
alloc_chrdev_region. The latter is the preferred solution since 
register_chrdev allocates a block of 256 minors, which seems to be 
overkill.

- The previewer and resizer basically create a new public API. Can you 
give a short description of that API and how it is used? I need some 
more information about it. In general I would say that a document 
describing these drivers and esp. the driver-specific public API is 
required.

- Can you test whether these patches apply to the latest v4l-dvb 
repository? There have been a lot of changes this weekend and it is 
probably good to check this.

Regards,

        Hans


On Saturday 30 August 2008 01:37:11 Aguirre Rodriguez, Sergio Alberto 
wrote:
> From: Sameer Venkatraman <sameerv@xxxxxx>
>
> V4L2: Adding internal IOCTLs for crop.
>
> Adding internal IOCTLs for crop.
>
> Signed-off-by: Sameer Venkatraman <sameerv@xxxxxx>
> Signed-off-by: Mohit Jalori <mjalori@xxxxxx>
> ---
>  include/media/v4l2-int-device.h |    6 ++++++
>  1 file changed, 6 insertions(+)
>
> Index: linux-omap-2.6/include/media/v4l2-int-device.h
> ===================================================================
> --- linux-omap-2.6.orig/include/media/v4l2-int-device.h	2008-08-25
> 12:19:09.000000000 -0500 +++
> linux-omap-2.6/include/media/v4l2-int-device.h	2008-08-25
> 12:19:10.000000000 -0500 @@ -170,6 +170,9 @@
>  	vidioc_int_queryctrl_num,
>  	vidioc_int_g_ctrl_num,
>  	vidioc_int_s_ctrl_num,
> +	vidioc_int_cropcap_num,
> +	vidioc_int_g_crop_num,
> +	vidioc_int_s_crop_num,
>  	vidioc_int_g_parm_num,
>  	vidioc_int_s_parm_num,
>
> @@ -266,6 +269,9 @@
>  V4L2_INT_WRAPPER_1(queryctrl, struct v4l2_queryctrl, *);
>  V4L2_INT_WRAPPER_1(g_ctrl, struct v4l2_control, *);
>  V4L2_INT_WRAPPER_1(s_ctrl, struct v4l2_control, *);
> +V4L2_INT_WRAPPER_1(cropcap, struct v4l2_cropcap, *);
> +V4L2_INT_WRAPPER_1(g_crop, struct v4l2_crop, *);
> +V4L2_INT_WRAPPER_1(s_crop, struct v4l2_crop, *);
>  V4L2_INT_WRAPPER_1(g_parm, struct v4l2_streamparm, *);
>  V4L2_INT_WRAPPER_1(s_parm, struct v4l2_streamparm, *);
>
>
> --
> video4linux-list mailing list
> Unsubscribe
> mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
> https://www.redhat.com/mailman/listinfo/video4linux-list


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list