Google
  Web www.spinics.net

Re: [PATCH] drivers/media/video/bttv-driver: Remove unneeded call to pci_dma_supported()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Tobias Klauser wrote:

In bttv-driver.c pci_dma_supported() is called after pci_set_dma_mask()
which already did check that for us. The attached patch removes the
unneeded call to pci_dma_supported()

Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxxx>

---

bttv-driver.c |    5 -----
1 files changed, 5 deletions(-)

diff -urpN -X dontdiff linux-2.6.13-rc2/drivers/media/video/bttv-driver.c linux-2.6.13-rc2~dma_mask/drivers/media/video/bttv-driver.c
--- linux-2.6.13-rc2/drivers/media/video/bttv-driver.c	2005-07-07 21:28:50.000000000 +0200
+++ linux-2.6.13-rc2~dma_mask/drivers/media/video/bttv-driver.c	2005-07-07 22:43:50.000000000 +0200
@@ -3880,11 +3881,6 @@ static int __devinit bttv_probe(struct p
        pci_set_master(dev);
	pci_set_command(dev);
	pci_set_drvdata(dev,btv);
-	if (!pci_dma_supported(dev,0xffffffff)) {
-		printk("bttv%d: Oops: no 32bit PCI DMA ???\n", btv->c.nr);
-		result = -EIO;
-		goto fail1;
-	}

        pci_read_config_byte(dev, PCI_CLASS_REVISION, &btv->revision);
        pci_read_config_byte(dev, PCI_LATENCY_TIMER, &lat);

--

Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list
Applied to video4linux cvs...

/Wed Jul 20 19:43:24 2005 UTC/ (55 seconds ago) by /mkrufky/
       * bttv-driver.c:
       - pci_dma_supported() is called after pci_set_dma_mask() which
         already did check that for us. The attached patch removes the
         unneeded call to pci_dma_supported()

       Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxxx>
       Signed-off-by: Michael Krufky <mkrufky@xxxxxxx>

--
Michael Krufky


--

Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

[Home]     [Older V4L]     [Linux DVB]     [Video Disk Recorder]     [Video Technology]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Plasma TVs]     [Video Projectors]     [PDAs]     [Xorg]     [Util Linux NG]     [Xfree86]     [Devices]     [Big List of Linux Books]     [Free Photo Albums]     [LCD TVs]     [Fedora Users]     [Webcams]     [Fedora Women]     [HDTV]     [ALSA Users]     [ALSA Devel]     [Stuff]     [SSH]     [Linux USB]

Powered by Linux

Google PageRank Checking tool