Re: [PATCH 04/15] cytune: use single loop for setting and getting ioctl() calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sami,

On Sun, May 4, 2014, at 17:49, Sami Kerola wrote:
> +		if (set_threshold)
> +			if (ioctl(file, CYSETTHRESH, threshold_val))
> +				err(EXIT_FAILURE, _("cannot set %s to threshold %d"), argv[i], threshold_val);
> +
> +		if (set_threshold_def)
> +			if (ioctl(file, CYSETDEFTHRESH, threshold_def_val))
> +				err(EXIT_FAILURE, _("cannot set %s to threshold %d"), argv[i], threshold_def_val);

Shouldn't the latter message contain the word "default"?

> +		if (set_timeout)
> +			if (ioctl(file, CYSETTIMEOUT, timeout_val))
> +				err(EXIT_FAILURE, _("cannot set %s to time threshold %d"), argv[i], timeout_val);

s/time threshold/timeout/ ?

> +		if (set_timeout_def)
> +			if (ioctl(file, CYSETDEFTIMEOUT, timeout_def_val))
> +				err(EXIT_FAILURE, _("cannot set %s to time threshold %d"), argv[i], timeout_def_val);

s/time threshold/default timeout/ ?

> +		if (get_defaults) {
> +			if (ioctl(file, CYGETDEFTHRESH, &threshold_value))
> +				err(EXIT_FAILURE, _("cannot get threshold for %s"), argv[i]);
> +			if (ioctl(file, CYGETDEFTIMEOUT, &timeout_value))
> +				err(EXIT_FAILURE, _("cannot get timeout for %s"), argv[i]);

Again the words "default"?

Benno

-- 
http://www.fastmail.fm - mmm... Fastmail...

--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux