Re: [PATCH] scriptreplay: Add --maxdelay option.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 10  19:25, Karel Zak wrote:
> On Mon, Feb 10, 2014 at 11:53:18AM +0100, Jesper Dahl Nyerup wrote:
> >  term-utils/scriptreplay.1 |  6 ++++++
> >  term-utils/scriptreplay.c | 15 ++++++++++++---
> >  2 files changed, 18 insertions(+), 3 deletions(-)
> 
>  Applied, thanks.

Back atcha.

> > +	double divi = 1, maxdelay = 10;
> 
>  I have used maxdelay = 0; it seems more readable :-)

Fine by me.

I had 0 in my patch initially, but changed it to 10. The only reason was
if someone someday decided to make the option argument optional, a
default value of 0 would effectively render scriptreplay(1) to be a
poorly implemented cat(1).

But let's cross that bridge when we reach it.

J.
-- 
Jesper Dahl Nyerup
Systems Engineer
One.com, nyerup@xxxxxxx

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux