Re: [pull] require C99, add robustness and small fixes

[Karel Zak <kzak@xxxxxxxxxx>]

On Fri, Jun 15, 2012 at 12:46:35PM +0200, Karel Zak wrote:
> On Mon, Jun 11, 2012 at 10:19:02PM +0200, Sami Kerola wrote:
> >       blkdev: add blkdev_scsi_type_to_name()
> >       lsblk: use blkdev_scsi_type_to_name()

 I have modified this code. It seems better to return static strings
 from blkdev_scsi_type_to_name() (Please, don't use xalloc.h stuff in
 lib/ as we use the functions from lib/ in shared libraries.)

 It seems better to have fallbacks for unknown SCSI types in
 applications (for example lsblk uses "part" or "disk").

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html