Re: [PATCH] fsck: don't free fstab table on parse failure

[Dave Reisner <d@xxxxxxxxxxxxxx>]

On Tue, Mar 27, 2012 at 08:53:58AM -0400, Dave Reisner wrote:
> Even if we fail parsing, fstab gets referenced later in the code (and
> will subsequently crash via heap corruption). Take the easy way out and
> simply avoid deallocating this table, as it will be freed for us on
> program exit regardless.
> 
> Signed-off-by: Dave Reisner <dreisner@xxxxxxxxxxxxx>
> ---

Pinging this, as it doesn't seem it was merged...

d

> Crash reproducible with 'FSTAB_FILE=/dev/null fsck <any-blockdev>'
> 
>  disk-utils/fsck.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
> index a019a69..44200d0 100644
> --- a/disk-utils/fsck.c
> +++ b/disk-utils/fsck.c
> @@ -430,7 +430,6 @@ static void load_fs_info(void)
>  	path = getenv("FSTAB_FILE");
>  
>  	if (mnt_table_parse_fstab(fstab, path)) {
> -		mnt_free_table(fstab);
>  		if (!path)
>  			path = mnt_get_fstab_path();
>  		if (errno)
> -- 
> 1.7.9.4
> 
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html