Re: hexsyntax.c using strtol on the offset parameter

[Simon de Vlieger <simon@xxxxxxxxxxxx>]

Karel,

thank you for your swift response and fix.

Simon

On 21 March 2012 19:44, Karel Zak <kzak@xxxxxxxxxx> wrote:
> On Wed, Mar 21, 2012 at 03:53:55PM +0100, Simon de Vlieger wrote:
>> The line I think I have it narrowed down to is line 92 of
>> util-linux/hexsyntax.c where the -s parameter is converted to a long.
>
>  Fixed. The code (as well as -n) was stupid. Now it supports all
>  possible suffixes (K,M,G,T,P,E,Y,Z) and the number is parsed as
>  uintmax_t.
>
>> Sadly the size of a 1 TB disk overflows the size of a long. Can the
>> off_t maybe be changed to use off64_t (if this is relevant) and use
>
>  The problem is not off_t, but strtol().
>
>  Thanks!
>
>    Karel
>
> --
>  Karel Zak  <kzak@xxxxxxxxxx>
>  http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html