Re: ipcs: header misalignment, unneeded gettextization

[Karel Zak <kzak@xxxxxxxxxx>]

On Sun, Aug 17, 2008 at 09:48:32PM +0200, Karel Zak wrote:
> 
>  Hi Benno,
> 
> On Fri, Aug 15, 2008 at 12:21:58AM +0200, Benno Schulenberg wrote:
> > Currently the output of 'ipcs -m' is slightly misaligned:
> > 
> > ------ Shared Memory Segments --------
> > key        shmid      owner      perms      bytes      nattch     status
> > 0x00000000 131072     ben       600        196608     2          dest
> > 0x00000000 98305      ben       600        393216     2          dest
> > 
> > The first patch (to follow) fixes that by adding a space before the 
> > perms data column.  It also correctly aligns the output of 'ipcs -mt' 
> > by removing a leading space from the "attached" column.

 Applied.

> > 
> > (I'm unsure though whether the second hunk is correct, and whether the
> > field widening in the third hunk is needed and correct.)
> 
>  it would be better to fix the headers alignment than touch the data.
>  It's possible that people use ipcs in their scripts and we shouldn't
>  change the positions of the data columns.

 Well, I've found that the output of "ipcs -m -t" is useless on
 terminal with 80 columns. It's stupid bug.

 We need to describe this change in ReleseNotes.

 Thanks,

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html