Re: a.out.h in text-utils/more.c

[Karel Zak <kzak@xxxxxxxxxx>]

On Wed, May 14, 2008 at 12:27:25PM -0400, Mike Frysinger wrote:
> On Wednesday 14 May 2008, Karel Zak wrote:
> > On Tue, May 13, 2008 at 10:20:40AM -0400, Mike Frysinger wrote:
> > > any problems with dropping the a.out.h include in text-utils/more.c and
> > > replacing the three defines with the actual constants ?  the constants
> > > are
> >
> >  Mike, you forgot to describe advantage of this change :-)
> 
> portability.  a.out.h is not POSIX and is a historical wart in today's ELF 
> world.  it's also broken for libc's that were relying on the kernel's a.out.h 
> but the kernel is no longer exporting it ... yes, this is a bug on the libc 
> side of things, but if nothing depended on a.out.h in the first place ...

 OK, makes sense. Send a patch.

> were talking about structures, i'd lean much more towards relying on the 

 Sure.

> header.  but we arent.  more.c uses the magic constants for a.out to detect 
> the format.  using this logic, why arent we using the magic constants from 
> elf.h ?

 go ahead, I've nothing against elf.h.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html