Re: [PATCH] Correct the error message given when we can't open the device.

[Karel Zak <kzak@xxxxxxxxxx>]

On Sun, Apr 06, 2008 at 11:45:57AM +0100, James Youngman wrote:
> Don't actually print %s in the error message, print the device name,
> as was obviously intended.  Also, print the error message
> corresponding to the errno value.
> ---
>  disk-utils/fsck.minix.c |   15 +++++++++++----
>  1 files changed, 11 insertions(+), 4 deletions(-)

 Applied.

> +die(const char *fmt, ...) {
> +  va_list ap;
> +  
> +  fprintf(stderr, "%s: ", program_name);
> +  va_start(ap, fmt);
> +  vfprintf(stderr, fmt, ap);
> +  va_end (ap);
> +  fputc('\n', stderr);
> +  leave(8);
>  }

 I've added:

 +static void die(const char *fmt, ...)
 +       __attribute__ ((__format__ (__printf__, 1, 2)));


 Thanks! (I'm going to review the rest of your patches tomorrow.)

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html