Re: [PATCH] fdisk: Message tweak.

[Mike Frysinger <vapier@xxxxxxxxxx>]

On Monday 07 April 2008, Benno Schulenberg wrote:
> Karel Zak wrote:
> > On Mon, Apr 07, 2008 at 10:50:47PM +0200, Benno Schulenberg wrote:
> > >  				printf (_("System type of partition %d is unchanged "
> > > -				        "to %x (%s)\n"), i + 1, sys, temp);
> > > +				        "at %x (%s)\n"), i + 1, sys, temp);
> >
> >                         ^^^
> >  why? I think the original message with "to" is correct.
>
> something is "changed to a new value",

yes

> or it is "unchanged at some value".

i dont think so ... "at" is generally for a location, not for describing 
values (at least in this instance).  if the message took the form of "value 
FOO at offset MOO", then "at" would be appropriate.  but i dont think that's 
the case.

> Or if you prefer: "...is unchanged: %x (%s)\n"

changing the wording to not using "to" nor "at" would be best i think.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.