Re: [PATCH] mntent: clean up gcc warnings

[Karel Zak <kzak@xxxxxxxxxx>]

On Mon, Oct 08, 2007 at 12:15:25PM -0700, Randy Dunlap wrote:
> On Mon, 8 Oct 2007 14:07:42 -0400 Mike Frysinger wrote:
> 
> > > And if mangle() just takes a "char *", casts are still needed, aren't they?
> > 
> > no, because the buffers would also be char *
> 
> OK, this is clearly better.  Thanks.
> 
> ---
> 
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> Fix gcc warnings from:
>   (try compilation with "-Wall -Wp,-D_FORTIFY_SOURCE=2")
> 
> mount_mntent.c:28: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness
> mount_mntent.c:129: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness
> mount_mntent.c:130: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness
> mount_mntent.c:131: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness
> mount_mntent.c:132: warning: pointer targets in passing argument 1 of 'mangle' differ in signedness
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

 Applied, thanks.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe util-linux-ng" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html